imply-cheddar opened a new pull request, #13652: URL: https://github.com/apache/druid/pull/13652
This adds implementations of semantic interfaces to optimize (eliminate object creation) the window processing on top of an ArrayListSegment. Tests are also added to cover the interplay between the semantic interfaces that are expected for this use case The actual business logic all exists inside of `ArrayListRowsAndColumns` so a review should start there. The tests in `CombinedSemanticInterfacesTest` are also of particular note for the interoperation dealt with here. Aside from the changes in those files, most of the other changes are renames/cleanups/refactors, there's also a few extra tests added and some fixes for warnings thrown in here and there. There is also a bit of cleanup in the PR deleting the no-longer-used `WindowAggregateProcessor` and all of the things that it solely depended on. This should've been done as part of the frame PR but was overlooked. This PR has: - [x] been self-reviewed. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
