hqx871 commented on code in PR #13303:
URL: https://github.com/apache/druid/pull/13303#discussion_r1066527041
##########
indexing-hadoop/src/main/java/org/apache/druid/indexer/DeterminePartitionsJob.java:
##########
@@ -437,13 +458,18 @@ protected void innerMap(
static class DeterminePartitionsDimSelectionMapperHelper
{
private final HadoopDruidIndexerConfig config;
- private final String partitionDimension;
+ private final List<List<String>> dimensionGroupingSet;
private final Map<Long, Integer> intervalIndexes;
+ private final boolean supportNullValue;
- DeterminePartitionsDimSelectionMapperHelper(HadoopDruidIndexerConfig
config, String partitionDimension)
+ DeterminePartitionsDimSelectionMapperHelper(HadoopDruidIndexerConfig
config)
{
this.config = config;
- this.partitionDimension = partitionDimension;
+
+ DimensionRangePartitionsSpec spec = (DimensionRangePartitionsSpec)
config.getPartitionsSpec();
+ final DimensionsSpec dimensionsSpec =
config.getSchema().getDataSchema().getDimensionsSpec();
+ this.dimensionGroupingSet = new
ArrayList<>(spec.getDimensionGroupingSet(dimensionsSpec));
+ this.supportNullValue = spec.supportNullValue();
Review Comment:
Hi @kfaraz, the single_dim does not support null values before, but actually
it can. Shall I remove this and just let the range and single_dim both support
null values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
