hqx871 commented on code in PR #13303:
URL: https://github.com/apache/druid/pull/13303#discussion_r1066515503
##########
core/src/main/java/org/apache/druid/indexer/partitions/SingleDimensionPartitionsSpec.java:
##########
@@ -146,6 +154,44 @@ public String
getForceGuaranteedRollupIncompatiblityReason()
return FORCE_GUARANTEED_ROLLUP_COMPATIBLE;
}
+ @Override
+ public List<List<String>> getDimensionGroupingSet(DimensionsSpec
dimensionsSpec)
Review Comment:
Hi @kfaraz, this method does not always returns a singleton list, as the
single_dim will try every dimension from dimensionsSpec.getDimensions() to
find the best when the partitionDimension is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
