github-code-scanning[bot] commented on code in PR #13303: URL: https://github.com/apache/druid/pull/13303#discussion_r1066567947
########## indexing-hadoop/src/test/java/org/apache/druid/indexer/DetermineRangePartitionsJobTest.java: ########## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexer; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; +import org.apache.druid.data.input.impl.CSVParseSpec; +import org.apache.druid.data.input.impl.DimensionsSpec; +import org.apache.druid.data.input.impl.StringInputRowParser; +import org.apache.druid.data.input.impl.TimestampSpec; +import org.apache.druid.indexer.partitions.DimensionRangePartitionsSpec; +import org.apache.druid.java.util.common.FileUtils; +import org.apache.druid.java.util.common.Intervals; +import org.apache.druid.java.util.common.granularity.Granularities; +import org.apache.druid.query.aggregation.AggregatorFactory; +import org.apache.druid.query.aggregation.LongSumAggregatorFactory; +import org.apache.druid.segment.indexing.DataSchema; +import org.apache.druid.segment.indexing.granularity.UniformGranularitySpec; +import org.apache.druid.timeline.partition.DimensionRangeShardSpec; +import org.junit.After; +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import java.io.File; +import java.io.IOException; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; +import java.util.Map; + + +@RunWith(Parameterized.class) +public class DetermineRangePartitionsJobTest +{ + private HadoopDruidIndexerConfig config; + private int expectedNumOfSegments; + private int[] expectedNumOfShardsForEachSegment; + private String[][][][] expectedStartEndForEachShard; + private File dataFile; + private File tmpDir; + + @Parameterized.Parameters(name = "assumeGrouped={0}, " + + "targetPartitionSize={1}, " + + "interval={2}" + + "expectedNumOfSegments={3}, " + + "expectedNumOfShardsForEachSegment={4}, " + + "expectedStartEndForEachShard={5}, " + + "data={6}, " + + "partitionDimensions={7}") + public static Collection<Object[]> constructFeed() + { + return Arrays.asList( + new Object[][]{ + { + false, + 3, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{4}, + new String[][][][]{ + { + {null, {"d.example.com"}}, + {{"d.example.com"}, {"g.example.com"}}, + {{"g.example.com"}, {"j.example.com"}}, + {{"j.example.com"}, null}, + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,US,200", + "2014102000,c.example.com,US,200", + "2014102000,d.example.com,US,250", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,US,963", + "2014102000,i.example.com,US,963", + "2014102000,j.example.com,US,333", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host") + }, + { + true, + 3, + "2014-10-22T00:00:00Z/P1D", + 1, + new int[]{4}, + new String[][][][]{ + { + {null, {"d.example.com", "US"}}, + {{"d.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"j.example.com", "US"}}, + {{"j.example.com", "US"}, null} + } + }, + ImmutableList.of( + "2014102200,a.example.com,CN,100", + "2014102200,b.exmaple.com,US,50", + "2014102200,c.example.com,US,200", + "2014102200,d.example.com,US,250", + "2014102200,e.example.com,US,123", + "2014102200,f.example.com,US,567", + "2014102200,g.example.com,US,11", + "2014102200,h.example.com,US,251", + "2014102200,i.example.com,US,963", + "2014102200,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + }, + { + false, + 3, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{4}, + new String[][][][]{ + { + {null, {"d.example.com", "US"}}, + {{"d.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"j.example.com", "US"}}, + {{"j.example.com", "US"}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,US,200", + "2014102000,c.example.com,US,200", + "2014102000,d.example.com,US,250", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,US,963", + "2014102000,i.example.com,US,963", + "2014102000,j.example.com,US,333", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + }, + { + true, + 6, + "2014-10-20T00:00:00Z/P3D", + 3, + new int[]{2, 2, 2}, + new String[][][][]{ + { + {null, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, null} + }, + { + {null, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, null} + }, + { + {null, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,CN,50", + "2014102000,c.example.com,CN,200", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,US,963", + "2014102000,j.example.com,US,333", + "2014102000,k.example.com,US,555", + "2014102100,a.example.com,CN,100", + "2014102100,b.exmaple.com,CN,50", + "2014102100,c.example.com,CN,200", + "2014102100,d.example.com,US,250", + "2014102100,e.example.com,US,123", + "2014102100,f.example.com,US,567", + "2014102100,g.example.com,US,11", + "2014102100,h.example.com,US,251", + "2014102100,i.example.com,US,963", + "2014102100,j.example.com,US,333", + "2014102100,k.example.com,US,555", + "2014102200,a.example.com,CN,100", + "2014102200,b.exmaple.com,CN,50", + "2014102200,c.example.com,CN,200", + "2014102200,d.example.com,US,250", + "2014102200,e.example.com,US,123", + "2014102200,f.example.com,US,567", + "2014102200,g.example.com,US,11", + "2014102200,h.example.com,US,251", + "2014102200,i.example.com,US,963", + "2014102200,j.example.com,US,333", + "2014102200,k.example.com,US,555" + ), + ImmutableList.of("host", "country") + }, + { + false, + 2, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{5}, + new String[][][][]{ + { + {null, {"c.example.com", null}}, + {{"c.example.com", null}, {"e.example.com", "US"}}, + {{"e.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"i.example.com", null}}, + {{"i.example.com", null}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,,200", + "2014102000,c.example.com,,200", + "2014102000,d.example.com,US,250", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,,963", + "2014102000,i.example.com,,963", + "2014102000,j.example.com,US,333", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + }, + { + true, + 2, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{5}, + new String[][][][]{ + { + {null, {"c.example.com", null}}, + {{"c.example.com", null}, {"e.example.com", "US"}}, + {{"e.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"i.example.com", null}}, + {{"i.example.com", null}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,,200", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,,963", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + } + } + ); + } + + public DetermineRangePartitionsJobTest( + boolean assumeGrouped, + Integer targetPartitionSize, + String interval, + int expectedNumOfSegments, + int[] expectedNumOfShardsForEachSegment, + String[][][][] expectedStartEndForEachShard, + List<String> data, + List<String> partitionDimensions + ) throws IOException + { + this.expectedNumOfSegments = expectedNumOfSegments; + this.expectedNumOfShardsForEachSegment = expectedNumOfShardsForEachSegment; + this.expectedStartEndForEachShard = expectedStartEndForEachShard; + + dataFile = File.createTempFile("test_website_data", "tmp"); + dataFile.deleteOnExit(); + tmpDir = FileUtils.createTempDir(); + tmpDir.deleteOnExit(); + + org.apache.commons.io.FileUtils.writeLines(dataFile, data); + + config = new HadoopDruidIndexerConfig( + new HadoopIngestionSpec( + new DataSchema( + "website", + HadoopDruidIndexerConfig.JSON_MAPPER.convertValue( + new StringInputRowParser( + new CSVParseSpec( + new TimestampSpec("timestamp", "yyyyMMddHH", null), + new DimensionsSpec( + DimensionsSpec.getDefaultSchemas(ImmutableList.of("host", "country")) + ), + null, + ImmutableList.of("timestamp", "host", "country", "visited_num"), + false, + 0 + ), + null + ), + Map.class + ), + new AggregatorFactory[]{new LongSumAggregatorFactory("visited_num", "visited_num")}, + new UniformGranularitySpec( + Granularities.DAY, + Granularities.NONE, + ImmutableList.of(Intervals.of(interval)) + ), + null, + HadoopDruidIndexerConfig.JSON_MAPPER + ), Review Comment: ## Deprecated method or constructor invocation Invoking [DataSchema.DataSchema](1) should be avoided because it has been deprecated. [Show more details](https://github.com/apache/druid/security/code-scanning/3646) ########## indexing-hadoop/src/test/java/org/apache/druid/indexer/DetermineRangePartitionsJobTest.java: ########## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexer; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; +import org.apache.druid.data.input.impl.CSVParseSpec; +import org.apache.druid.data.input.impl.DimensionsSpec; +import org.apache.druid.data.input.impl.StringInputRowParser; +import org.apache.druid.data.input.impl.TimestampSpec; +import org.apache.druid.indexer.partitions.DimensionRangePartitionsSpec; +import org.apache.druid.java.util.common.FileUtils; +import org.apache.druid.java.util.common.Intervals; +import org.apache.druid.java.util.common.granularity.Granularities; +import org.apache.druid.query.aggregation.AggregatorFactory; +import org.apache.druid.query.aggregation.LongSumAggregatorFactory; +import org.apache.druid.segment.indexing.DataSchema; +import org.apache.druid.segment.indexing.granularity.UniformGranularitySpec; +import org.apache.druid.timeline.partition.DimensionRangeShardSpec; +import org.junit.After; +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import java.io.File; +import java.io.IOException; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; +import java.util.Map; + + +@RunWith(Parameterized.class) +public class DetermineRangePartitionsJobTest +{ + private HadoopDruidIndexerConfig config; + private int expectedNumOfSegments; + private int[] expectedNumOfShardsForEachSegment; + private String[][][][] expectedStartEndForEachShard; + private File dataFile; + private File tmpDir; + + @Parameterized.Parameters(name = "assumeGrouped={0}, " + + "targetPartitionSize={1}, " + + "interval={2}" + + "expectedNumOfSegments={3}, " + + "expectedNumOfShardsForEachSegment={4}, " + + "expectedStartEndForEachShard={5}, " + + "data={6}, " + + "partitionDimensions={7}") + public static Collection<Object[]> constructFeed() + { + return Arrays.asList( + new Object[][]{ + { + false, + 3, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{4}, + new String[][][][]{ + { + {null, {"d.example.com"}}, + {{"d.example.com"}, {"g.example.com"}}, + {{"g.example.com"}, {"j.example.com"}}, + {{"j.example.com"}, null}, + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,US,200", + "2014102000,c.example.com,US,200", + "2014102000,d.example.com,US,250", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,US,963", + "2014102000,i.example.com,US,963", + "2014102000,j.example.com,US,333", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host") + }, + { + true, + 3, + "2014-10-22T00:00:00Z/P1D", + 1, + new int[]{4}, + new String[][][][]{ + { + {null, {"d.example.com", "US"}}, + {{"d.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"j.example.com", "US"}}, + {{"j.example.com", "US"}, null} + } + }, + ImmutableList.of( + "2014102200,a.example.com,CN,100", + "2014102200,b.exmaple.com,US,50", + "2014102200,c.example.com,US,200", + "2014102200,d.example.com,US,250", + "2014102200,e.example.com,US,123", + "2014102200,f.example.com,US,567", + "2014102200,g.example.com,US,11", + "2014102200,h.example.com,US,251", + "2014102200,i.example.com,US,963", + "2014102200,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + }, + { + false, + 3, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{4}, + new String[][][][]{ + { + {null, {"d.example.com", "US"}}, + {{"d.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"j.example.com", "US"}}, + {{"j.example.com", "US"}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,US,200", + "2014102000,c.example.com,US,200", + "2014102000,d.example.com,US,250", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,US,963", + "2014102000,i.example.com,US,963", + "2014102000,j.example.com,US,333", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + }, + { + true, + 6, + "2014-10-20T00:00:00Z/P3D", + 3, + new int[]{2, 2, 2}, + new String[][][][]{ + { + {null, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, null} + }, + { + {null, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, null} + }, + { + {null, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,CN,50", + "2014102000,c.example.com,CN,200", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,US,963", + "2014102000,j.example.com,US,333", + "2014102000,k.example.com,US,555", + "2014102100,a.example.com,CN,100", + "2014102100,b.exmaple.com,CN,50", + "2014102100,c.example.com,CN,200", + "2014102100,d.example.com,US,250", + "2014102100,e.example.com,US,123", + "2014102100,f.example.com,US,567", + "2014102100,g.example.com,US,11", + "2014102100,h.example.com,US,251", + "2014102100,i.example.com,US,963", + "2014102100,j.example.com,US,333", + "2014102100,k.example.com,US,555", + "2014102200,a.example.com,CN,100", + "2014102200,b.exmaple.com,CN,50", + "2014102200,c.example.com,CN,200", + "2014102200,d.example.com,US,250", + "2014102200,e.example.com,US,123", + "2014102200,f.example.com,US,567", + "2014102200,g.example.com,US,11", + "2014102200,h.example.com,US,251", + "2014102200,i.example.com,US,963", + "2014102200,j.example.com,US,333", + "2014102200,k.example.com,US,555" + ), + ImmutableList.of("host", "country") + }, + { + false, + 2, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{5}, + new String[][][][]{ + { + {null, {"c.example.com", null}}, + {{"c.example.com", null}, {"e.example.com", "US"}}, + {{"e.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"i.example.com", null}}, + {{"i.example.com", null}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,,200", + "2014102000,c.example.com,,200", + "2014102000,d.example.com,US,250", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,,963", + "2014102000,i.example.com,,963", + "2014102000,j.example.com,US,333", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + }, + { + true, + 2, + "2014-10-20T00:00:00Z/P1D", + 1, + new int[]{5}, + new String[][][][]{ + { + {null, {"c.example.com", null}}, + {{"c.example.com", null}, {"e.example.com", "US"}}, + {{"e.example.com", "US"}, {"g.example.com", "US"}}, + {{"g.example.com", "US"}, {"i.example.com", null}}, + {{"i.example.com", null}, null} + } + }, + ImmutableList.of( + "2014102000,a.example.com,CN,100", + "2014102000,b.exmaple.com,US,50", + "2014102000,c.example.com,,200", + "2014102000,d.example.com,US,250", + "2014102000,e.example.com,US,123", + "2014102000,f.example.com,US,567", + "2014102000,g.example.com,US,11", + "2014102000,h.example.com,US,251", + "2014102000,i.example.com,,963", + "2014102000,j.example.com,US,333" + ), + ImmutableList.of("host", "country") + } + } + ); + } + + public DetermineRangePartitionsJobTest( + boolean assumeGrouped, + Integer targetPartitionSize, + String interval, + int expectedNumOfSegments, + int[] expectedNumOfShardsForEachSegment, + String[][][][] expectedStartEndForEachShard, + List<String> data, + List<String> partitionDimensions + ) throws IOException + { + this.expectedNumOfSegments = expectedNumOfSegments; + this.expectedNumOfShardsForEachSegment = expectedNumOfShardsForEachSegment; + this.expectedStartEndForEachShard = expectedStartEndForEachShard; + + dataFile = File.createTempFile("test_website_data", "tmp"); Review Comment: ## Local information disclosure in a temporary directory Local information disclosure vulnerability due to use of file readable by other local users. [Show more details](https://github.com/apache/druid/security/code-scanning/3647) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
