zachjsh commented on code in PR #13627:
URL: https://github.com/apache/druid/pull/13627#discussion_r1066564475
##########
server/src/main/java/org/apache/druid/catalog/model/TableDefn.java:
##########
@@ -99,26 +93,13 @@ public void validateColumns(List<ColumnSpec> columns,
ObjectMapper jsonMapper)
if (!names.add(colSpec.name())) {
throw new IAE("Duplicate column name: " + colSpec.name());
}
- ColumnDefn.ResolvedColumn resolvedCol = resolveColumn(colSpec);
- resolvedCol.validate(jsonMapper);
+ colSpec.validate();
+ validateColumn(colSpec);
}
}
- /**
- * Resolve the column type to produce a composite object that holds
- * both the definition and the column spec.
- */
- public ColumnDefn.ResolvedColumn resolveColumn(ColumnSpec spec)
+ protected void validateColumn(ColumnSpec colSpec)
Review Comment:
I assume this will be defined at some later time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
