zachjsh commented on code in PR #13627:
URL: https://github.com/apache/druid/pull/13627#discussion_r1066563594
##########
server/src/main/java/org/apache/druid/catalog/model/TableDefn.java:
##########
@@ -47,35 +46,30 @@ public class TableDefn extends ObjectDefn
*/
public static final String DESCRIPTION_PROPERTY = "description";
- private final Map<String, ColumnDefn> columnDefns;
+ private final Map<String, PropertyDefn<?>> columnProperties;
public TableDefn(
final String name,
final String typeValue,
final List<PropertyDefn<?>> properties,
- final List<ColumnDefn> columnDefns
+ final List<PropertyDefn<?>> columnProperties
)
{
super(
name,
typeValue,
CatalogUtils.concatLists(
Collections.singletonList(
- new ModelProperties.StringPropertyDefn(DESCRIPTION_PROPERTY,
null)
+ new ModelProperties.StringPropertyDefn(DESCRIPTION_PROPERTY)
),
properties
)
);
- this.columnDefns = columnDefns == null ? Collections.emptyMap() :
toColumnMap(columnDefns);
+ this.columnProperties = toPropertyMap(columnProperties);
}
- public static Map<String, ColumnDefn> toColumnMap(final List<ColumnDefn>
colTypes)
+ public void bind(TableDefnRegistry registry)
Review Comment:
I assume this will be defined at some later time? what will this function
do, javadoc would be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
