imply-cheddar commented on code in PR #13627: URL: https://github.com/apache/druid/pull/13627#discussion_r1068754168
########## sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidCalciteSchemaModule.java: ########## @@ -64,7 +64,7 @@ public void configure(Binder binder) } @Provides - @Singleton + @LazySingleton Review Comment: `@Singleton` should NEVER be used. If it exists in any of our code we should remove it immediately. That's the reason. If anything it deserves a checkstyle validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
