paul-rogers commented on code in PR #13627:
URL: https://github.com/apache/druid/pull/13627#discussion_r1068789221
##########
server/src/main/java/org/apache/druid/catalog/model/table/ExternalTableSpec.java:
##########
@@ -28,13 +28,13 @@
/**
* Catalog form of an external table specification used to pass along the three
* components needed for an external table in MSQ ingest. Just like
- * {@code ExternalTableSource}, except that the parameters are not required
- * to be non-null.
+ * {@code ExternalTableSource}, except that the class is visible in this
+ * module.
*/
public class ExternalTableSpec
{
- @Nullable public final InputSource inputSource;
- @Nullable public final InputFormat inputFormat;
+ public final InputSource inputSource;
Review Comment:
Yes. That's the implication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
