paul-rogers commented on code in PR #13627:
URL: https://github.com/apache/druid/pull/13627#discussion_r1069786027
##########
extensions-core/s3-extensions/pom.xml:
##########
@@ -114,7 +120,6 @@
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-sts</artifactId>
- <version>${aws.sdk.version}</version>
Review Comment:
Yes. We have the following in the root `pom.xml`:
```xml
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-sts</artifactId>
<version>${aws.sdk.version}</version>
</dependency>
```
When we manage versions at the root level, it is redundant (and error-prone)
to repeat the version in child POMs. My IDE gives a warning when we do so. This
change acknowledges that we manage versions for this artifact at the root level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
