TSFenwick commented on code in PR #13670: URL: https://github.com/apache/druid/pull/13670#discussion_r1085730737
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerContext.java: ########## @@ -73,4 +74,6 @@ DruidNode selfNode(); Bouncer processorBouncer(); + + Emitter emitter(); Review Comment: We are getting this from `TaskToolBox` and the emitter there isn't nullable ########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/MSQFilteredEmitterWarningPublisher.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.msq.indexing.error; + +import org.apache.druid.java.util.emitter.core.Emitter; +import org.apache.druid.java.util.emitter.core.Event; +import org.apache.druid.java.util.emitter.core.EventMap; + +import javax.annotation.Nullable; +import java.io.IOException; +import java.util.Set; + +public class MSQFilteredEmitterWarningPublisher implements MSQWarningPublisher +{ + + private final String workerId; + private final String controllerTaskId; + private final String taskId; + @Nullable + private final String host; + private final Emitter emitter; + private final Set<String> acceptableErrorCode; + + public MSQFilteredEmitterWarningPublisher( + final String workerId, + final String controllerTaskId, + final String taskId, + @Nullable final String host, + Emitter emitter, + Set<String> acceptableErrorCode + ) + { + this.workerId = workerId; + this.controllerTaskId = controllerTaskId; + this.taskId = taskId; + this.host = host; + this.emitter = emitter; + this.acceptableErrorCode = acceptableErrorCode; + } + + @Override + public void publishException(int stageNumber, Throwable e) + { + String errorCode = MSQErrorReport.getFaultFromException(e).getErrorCode(); + if (acceptableErrorCode.contains(errorCode)) { + MSQErrorReport errorReport = MSQErrorReport.fromException(workerId, host, stageNumber, e); + String errorMessage = errorReport.getFault().getErrorMessage(); + // todo use an actual event type that has the correct feed. + // todo see if i can find group ID as well, maybe thats controller task id??? Review Comment: thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
