TSFenwick commented on code in PR #13670:
URL: https://github.com/apache/druid/pull/13670#discussion_r1072731064
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/MSQWarningReportLimiterPublisher.java:
##########
@@ -108,6 +115,12 @@ public void publishException(int stageNumber, Throwable e)
return;
}
}
+ if (CannotParseExternalDataFault.CODE.equals(errorCode)) {
Review Comment:
I'm not sure i follow
> This is what I would do:
> Rename MSQWarningReportPublisher to ExceptionPublisher.
>
> Create a new CompositeExceptionPublisher.
>
> One implementation can be of a FilteredEmitterExceptionPublisher where in
the constructor you take the error code.
Are you saying create another class that implements the interface that i
will rename.
The `CompositeExceptionPublisher` i don't understand?
`FilteredEmitterExceptionPublisher` i also don't understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
