paul-rogers opened a new pull request, #13780:
URL: https://github.com/apache/druid/pull/13780

   This is a follow-up to the earlier PR that introduced input-source specific 
table functions (e.g. `http`, `s3`, `localfiles`, etc.) This PR is mostly 
cleanup and bug fixes and is a spin-off of the effort to integrate the catalog 
with Calcite. These changes are done as a separate PR to keep each PR to a 
reasonable size.
   
   * Fixes various bugs
   * Improves the structure of the table function classes 
   * Adds unit and integration tests
   
   In particular, this PR fixes an issue with the feature that allows an SQL 
feature with the `extern` function.
   
   #### Release note
   
   No user-visible changes: just refinements to functionality already described 
in an earlier PR.
   
   <hr>
   
   This PR has:
   
   - [X] been self-reviewed.
   - [X] a release note entry in the PR description.
   - [X] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [X] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [X] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [X] added integration tests.
   - [X] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to