paul-rogers commented on code in PR #13780:
URL: https://github.com/apache/druid/pull/13780#discussion_r1103370272
##########
server/src/main/java/org/apache/druid/catalog/model/table/HttpInputSourceDefn.java:
##########
@@ -172,6 +172,14 @@ public void validate(ResolvedExternalTable table)
super.validate(table);
}
+ @Override
+ protected void auditInputSource(Map<String, Object> jsonMap)
+ {
+ // A partial table may not include the URI parameter, but it is
+ // needed to serialize the input source.
+ jsonMap.putIfAbsent(URIS_PARAMETER, "http://bogus.com";);
Review Comment:
Everyone asks this. I'm sad that the comment doesn't explain it. You can
have a partial input source definition: "with URIs to be named later." But, our
input source class requires all the details. In order to validate the bits we
_do_ have , we have to make up bits to make Druid happy.
This is when validating a (partial) catalog definition. When the user uses
this spec in a function, we do require all information be provided to create a
"complete" table. We don't use bogus values at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
