zachjsh commented on code in PR #13780:
URL: https://github.com/apache/druid/pull/13780#discussion_r1102132395
##########
server/src/main/java/org/apache/druid/catalog/model/table/FormattedInputSourceDefn.java:
##########
@@ -95,7 +95,10 @@ protected List<ParameterDefn> addFormatParameters(
)
{
final List<ParameterDefn> toAdd = new ArrayList<>();
- final ParameterDefn formatProp = new Parameter(FORMAT_PARAMETER,
ParameterType.VARCHAR, false);
+ // While the format parameter is required, we mark it as optional. Else
+ // if the source defines optional parameters, they will still be ignored
Review Comment:
if the format* defines optional parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
