jwitko opened a new pull request, #13796:
URL: https://github.com/apache/druid/pull/13796

   ### Description
   This PR adds customizable global and per-container environment variable 
appended array objects.
   
   There already exists the ability to add basic key/value configurable 
variables via the global `configVars` and per-container `config` maps however 
the format they are implemented in does not support the broader Kubernetes 
environment variable use cases.
   
   For example if a person wanted to pass in 
`druid_metadata_storage_connector_password` via an existing Kubernetes secret 
this would not be possible in the existing config.
   
   This PR would allow for pulling of environment variables from secrets, 
configmaps, and any other K8s supported environment variable configuration on a 
global and per-container basis.
   
   It should also be noted that the `Chart.yaml` version is bumped to `0.3.6` 
from `0.3.3` because #13747 and #13783 came first.
   
   #### Release note
   Add customizable global and per-container env vars to helm chart
   
   <hr>
   
   This PR has:
   
   - [X] been self-reviewed.
   - [X] added documentation for new or modified features or behaviors.
   - [X] a release note entry in the PR description.
   - [X] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [X] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [X] been tested in a test Druid cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to