jwitko commented on code in PR #13796:
URL: https://github.com/apache/druid/pull/13796#discussion_r1137209117
##########
helm/druid/templates/broker/deployment.yaml:
##########
@@ -65,10 +65,16 @@ spec:
valueFrom: {fieldRef: {fieldPath: metadata.name}}
- name: POD_NAMESPACE
valueFrom: {fieldRef: {fieldPath: metadata.namespace}}
+ {{- with .Values.env }}
+ {{- toYaml . | nindent 10 }}
+ {{- end }}
{{- range $key, $val := .Values.broker.config }}
- name: {{ $key }}
value: {{ $val | quote }}
- {{- end}}
+ {{- end }}
+ {{- with .Values.broker.env }}
Review Comment:
Since there is no other thing referencing environment variables I didn't see
a need to get more complicated than `env` but if its what is needed to get this
merged then sure, I'm not married to the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
