georgew5656 commented on code in PR #13796:
URL: https://github.com/apache/druid/pull/13796#discussion_r1137359611
##########
helm/druid/templates/broker/deployment.yaml:
##########
@@ -65,10 +65,16 @@ spec:
valueFrom: {fieldRef: {fieldPath: metadata.name}}
- name: POD_NAMESPACE
valueFrom: {fieldRef: {fieldPath: metadata.namespace}}
+ {{- with .Values.env }}
+ {{- toYaml . | nindent 10 }}
+ {{- end }}
{{- range $key, $val := .Values.broker.config }}
- name: {{ $key }}
value: {{ $val | quote }}
- {{- end}}
+ {{- end }}
+ {{- with .Values.broker.env }}
Review Comment:
i just prefer it this way to make it clear we aren't overwriting the entire
environment variables section with the extra env variable, just appending
##########
helm/druid/templates/middleManager/statefulset.yaml:
##########
@@ -73,7 +73,7 @@ spec:
topologyKey: kubernetes.io/hostname
labelSelector:
matchLabels:
- app: "{{ template "druid.name" . }}"
+ app: {{ template "druid.name" . | quote }}
Review Comment:
makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
