gianm commented on PR #13798: URL: https://github.com/apache/druid/pull/13798#issuecomment-1429195314
We definitely need something like this. Thank you for working on it. I mentioned on the issue #13123 that it would be good to be able to be able to merge the MSQ task error system into this new DruidException system. It currently isn't, because the serialized JSON formats are different. Let's try to reconcile that. There are a couple of approaches we can take. 1. Modify the JSON structure of DruidException (seems like this is generated by StandardRestExceptionEncoder) to match either MSQErrorReport or MSQFault. Not totally sure which one is the correct level, but it would be one of those two. Then, we can replace all of those with DruidExceptions without affecting the serialized JSON. 2. Stick with the form of DruidException in this PR. Modify MSQ to serialize _both_ DruidExceptions and its current exception form. Introduce a config setting that switches off the current form, and deprecate the current form. Later on, drop it. (The usual way we would migrate an API's response structure.) The rationale is that these two error response JSON structures are very similar in intent, and we should be kind to users by using one structure rather than two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
