paul-rogers commented on code in PR #13798:
URL: https://github.com/apache/druid/pull/13798#discussion_r1110439629
##########
server/src/main/java/org/apache/druid/server/security/PreResponseAuthorizationCheckFilter.java:
##########
@@ -90,7 +89,7 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
// (e.g. OverlordServletProxy), so this is not implemented for now.
handleAuthorizationCheckError(
StringUtils.format(
- "Request did not have an authorization check performed, original
response status[%s].",
+ "Request did not have an authorization check performed, original
response status: %s",
Review Comment:
See comment in the main discussion. This is a convention in _Druid_. It is
not a convention elsewhere. We're mainly focused on end users here. Will your
typical end user expect values in brackets? Or, should we use this format just
for internal messages and log messages? Maybe omit brackets for `USER`
messages, include for all others. Something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
