churromorales commented on code in PR #13804:
URL: https://github.com/apache/druid/pull/13804#discussion_r1120735101
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidKubernetesPeonClient.java:
##########
@@ -121,12 +121,12 @@ public JobResponse waitForJobCompletion(K8sTaskId taskId,
long howLong, TimeUnit
public boolean cleanUpJob(K8sTaskId taskId)
{
if (!debugJobs) {
- Boolean result = clientApi.executeRequest(client -> client.batch()
- .v1()
- .jobs()
-
.inNamespace(namespace)
-
.withName(taskId.getK8sTaskId())
- .delete());
+ Boolean result = clientApi.executeRequest(client -> !client.batch()
+ .v1()
+ .jobs()
+
.inNamespace(namespace)
+
.withName(taskId.getK8sTaskId())
+
.delete().isEmpty());
Review Comment:
```List<StatusDetails> delete();``` used to return true or false i believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
