churromorales commented on PR #13804: URL: https://github.com/apache/druid/pull/13804#issuecomment-1454241784
> @churromorales - can you address the build failures? I addressed them in a comment above, but maybe it was missed. So I had tests for the `DruidKubernetesPeonClient` class, then i upgraded a client library and had to change some things. but the functions were all tested before. Now i would expect that if tests pass I would be good, since it was already tested before. But turns out if you have to make any changes to make the new library apis work, then code coverage complains. It is unfortunate here, because I didn't change any behavior. I can add more tests, but they wont be meaningful here, I believe the build problems are all because I updated the library and had to make some code changes to make it work. There are no logic changes here, except for the issue in 1.25, which I did test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
