churromorales commented on code in PR #13804:
URL: https://github.com/apache/druid/pull/13804#discussion_r1125113300
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidKubernetesPeonClient.java:
##########
@@ -106,13 +104,15 @@ public JobResponse waitForJobCompletion(K8sTaskId taskId,
long howLong, TimeUnit
.inNamespace(namespace)
.withName(taskId.getK8sTaskId())
.waitUntilCondition(
- x -> x != null && x.getStatus() != null &&
x.getStatus().getActive() == null,
+ x -> x != null && x.getStatus() != null &&
x.getStatus().getActive() == null
+ && (x.getStatus().getFailed() != null ||
x.getStatus().getSucceeded() !=null),
Review Comment:
@nlippis I believe you can test by taking this commit and making that small
change and apply it onto the 25 branch. I think if it works for you, ill
resubmit this with the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
