clintropolis opened a new pull request, #13890:
URL: https://github.com/apache/druid/pull/13890
### Description
This PR modifies the SQL `CAST` operator conversion to use
`Calcites.getColumnTypeForRelDataType` to convert calcite types to native Druid
types instead of using its own custom `SqlTypeName ` to `ExprType` mapping to
make it more consistent with other SQL to Druid type conversions done for most
other operators. This allows it to handle some additional casts which were not
previously supported, such as those with ARRAY types. The test added to
`CalciteMultiValueStringQueryTest` was not able to be planned prior to the
changes to the `CAST` operator since during planning explicit casts would be
added which would then fail since the mapping table was missing arrays.
Switching `CAST` to use `Calcites.getColumnTypeForRelDataType` also required
making a small adjustment to this method to be able to handle
`SqlTypeName.DAY_INTERVAL_TYPES` and `SqlTypeName.YEAR_INTERVAL_TYPES` as a
Druid `LONG` type. This also allows some additional expressions to be planned
that were not previously supported, shown in the changes to `ExpressionsTest`,
`GreatestExpressionTest`, and `LeastExpressionTest`.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
