clintropolis commented on code in PR #13890:
URL: https://github.com/apache/druid/pull/13890#discussion_r1127934496
##########
sql/src/test/java/org/apache/druid/sql/calcite/expression/ExpressionsTest.java:
##########
@@ -1779,8 +1778,7 @@ public void testTimeMinusYearMonthInterval()
DruidExpression.functionCall("timestamp_shift"),
ImmutableList.of(
DruidExpression.ofColumn(ColumnType.LONG, "t"),
- // RexNode type "interval year to month" is not reported as
ColumnType.STRING
- DruidExpression.ofLiteral(null,
DruidExpression.stringLiteral("P13M")),
+ DruidExpression.ofLiteral(ColumnType.LONG,
DruidExpression.stringLiteral("P13M")),
Review Comment:
ok, updated to handle intervals as STRINGS so they match the argument
literals in plans, but also handle them as longs for casting (and also
reduction). I suppose instead I could just drop intervals from being handled by
`Calcites.getColumnTypeForRelDataType` like it was before and just handle them
in the cast, but string seems the most correct i think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
