clintropolis commented on code in PR #13890:
URL: https://github.com/apache/druid/pull/13890#discussion_r1127900569
##########
sql/src/test/java/org/apache/druid/sql/calcite/expression/ExpressionsTest.java:
##########
@@ -1779,8 +1778,7 @@ public void testTimeMinusYearMonthInterval()
DruidExpression.functionCall("timestamp_shift"),
ImmutableList.of(
DruidExpression.ofColumn(ColumnType.LONG, "t"),
- // RexNode type "interval year to month" is not reported as
ColumnType.STRING
- DruidExpression.ofLiteral(null,
DruidExpression.stringLiteral("P13M")),
+ DruidExpression.ofLiteral(ColumnType.LONG,
DruidExpression.stringLiteral("P13M")),
Review Comment:
hmm, so this was a result of merging the rules from cast into
`Calcites.getColumnTypeForRelDataType` which had interval types as LONG, but
agree it does look a bit strange so will fix to report these interval types as
strings instead and see what that breaks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
