gianm commented on code in PR #13902:
URL: https://github.com/apache/druid/pull/13902#discussion_r1130197588
##########
sql/src/test/resources/calcite/tests/window/wikipediaScanWindow.sqlTest:
##########
@@ -0,0 +1,23 @@
+type: "operatorValidation"
+
+sql: |
+ SELECT
+ __time,
+ "user",
+ page,
+ LAG(page, 1) OVER (PARTITION BY "user" ORDER BY __time) as priorPage
+ FROM wikipedia
+
+expectedOperators:
+ - { type: "naiveSort", columns: [ { column: "user", direction: "ASC" }, {
column: "__time", direction: "ASC" } ]}
+ - { type: "naivePartition", partitionColumns: [ "user" ] }
+ - type: "window"
+ processor:
+ type: "offset"
+ inputColumn: page
+ outputColumn: w0
+ offset: -1
+
+# Not correct: there should actually be results here. Therefore, currently,
this test only verifies that the
+# query is planned as expected, not that the results are correct.
+expectedResults: []
Review Comment:
It is not failing. I am not sure why the results are empty. The native query
looks good to me so I figured something was wrong with the execution part. I
looked into it a little but in that time wasn't able to figure out where the
results were getting dropped. One difference here is that the base query type
is `scan`, all other tests have a base query type `groupBy`. Is that something
that is supposed to work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
