imply-cheddar commented on code in PR #13902:
URL: https://github.com/apache/druid/pull/13902#discussion_r1130319913
##########
sql/src/test/resources/calcite/tests/window/wikipediaScanWindow.sqlTest:
##########
@@ -0,0 +1,23 @@
+type: "operatorValidation"
+
+sql: |
+ SELECT
+ __time,
+ "user",
+ page,
+ LAG(page, 1) OVER (PARTITION BY "user" ORDER BY __time) as priorPage
+ FROM wikipedia
+
+expectedOperators:
+ - { type: "naiveSort", columns: [ { column: "user", direction: "ASC" }, {
column: "__time", direction: "ASC" } ]}
+ - { type: "naivePartition", partitionColumns: [ "user" ] }
+ - type: "window"
+ processor:
+ type: "offset"
+ inputColumn: page
+ outputColumn: w0
+ offset: -1
+
+# Not correct: there should actually be results here. Therefore, currently,
this test only verifies that the
+# query is planned as expected, not that the results are correct.
+expectedResults: []
Review Comment:
Oooooh, yeah, scan doesn't work because it doesn't actually produce a good
RowSignature for the ArrayListSegment (this is addressed some in
https://github.com/apache/druid/pull/13773). So that's likely the culprit.
Though, I would've expected that to generate an exception...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
