somu-imply commented on code in PR #13922:
URL: https://github.com/apache/druid/pull/13922#discussion_r1132992902
##########
processing/src/main/java/org/apache/druid/segment/UnnestStorageAdapter.java:
##########
@@ -138,13 +135,16 @@ public Sequence<Cursor> makeCursors(
retVal.getColumnSelectorFactory(),
unnestColumn,
outputColumnName,
- allowSet
+ filterPair.rhs
);
}
+ // This is needed at this moment for nested queries
+ // Future developer would want to move the virtual columns
+ // inside the UnnestCursor and wrap the columnSelectorFactory
return PostJoinCursor.wrap(
retVal,
virtualColumns,
- filterPair.rhs
+ null
Review Comment:
The rationale was that going forward the filter on the right will be
available on top of the uncollect and Eric and I were discussing if we should
pull it into the UnnestDataSource. I agree that the filter can be on the
PostJoinCursor. I was also planning of moving in the virtualColumns into the
cursors. If keeping it in PostJoin cursor is simpler and we are doing the same
amount of work, I'll be happy moving it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
