somu-imply commented on code in PR #13922:
URL: https://github.com/apache/druid/pull/13922#discussion_r1134471691
##########
processing/src/main/java/org/apache/druid/segment/UnnestStorageAdapter.java:
##########
@@ -120,27 +117,27 @@ public Sequence<Cursor> makeCursors(
retVal,
retVal.getColumnSelectorFactory(),
unnestColumn,
- outputColumnName,
- allowSet
+ outputColumnName
);
} else {
retVal = new UnnestColumnValueSelectorCursor(
retVal,
retVal.getColumnSelectorFactory(),
unnestColumn,
- outputColumnName,
- allowSet
+ outputColumnName
);
}
} else {
retVal = new UnnestColumnValueSelectorCursor(
retVal,
retVal.getColumnSelectorFactory(),
unnestColumn,
- outputColumnName,
- allowSet
+ outputColumnName
);
}
+ // This is needed at this moment for nested queries
+ // Future developer would want to move the virtual columns
Review Comment:
My bad removed the stale comments and updated the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
