cryptoe commented on code in PR #13909:
URL: https://github.com/apache/druid/pull/13909#discussion_r1135041472


##########
docs/multi-stage-query/api.md:
##########
@@ -528,6 +530,10 @@ The response shows an example report for a query.
               "frames": [
                 73
               ]
+            },
+            "segmentGenerationProgress": {
+              "type": "segmentGenerationProgress",

Review Comment:
   I was thinking something like this: 
   ```json
   {
    "1": { 
               "input0": {
                 "type": "channel",
                 "rows": [
                   465346
                 ],
                 "files": [
                   1
                 ],
                 "totalFiles": [
                   1
                 ]
               },
               "output": {
                 "type": "segmentGenerationProgress",
                 "rowsProcessed": 465346 
              }
          }
   }
   
   ```
   
   but I think that would complicate what type of output counter since we have 
a type:"channel" inside output. 
   
   I think the correct structure should be to remove the "type" but that should 
be outside the scope of this PR.
   ```json
   {
   "output":{
     "channel":{
        "foo":"bar"
        }
     "segmentGenerationProgress": {
        "foo1":"bar1"
      }
    }
   }
     
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to