adarshsanjeev commented on code in PR #13909:
URL: https://github.com/apache/druid/pull/13909#discussion_r1139970789
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/SegmentGeneratorFrameProcessor.java:
##########
@@ -202,7 +211,14 @@ private void addFrame(final Frame frame)
try {
rowsWritten++;
+ segmentGenerationProgressCounter.incrementRowProcessedCount();
appenderator.add(segmentIdWithShardSpec, inputRow, null);
+ if (rowsWritten - lastCounterUpdatedRows > 1000) {
Review Comment:
I have made the change. I think this would still end up happening to a small
extent, if say some rows are not persisted by the time the last rows are
processed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
