cryptoe commented on code in PR #13909:
URL: https://github.com/apache/druid/pull/13909#discussion_r1141420148
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/SegmentGeneratorFrameProcessor.java:
##########
@@ -202,7 +211,14 @@ private void addFrame(final Frame frame)
try {
rowsWritten++;
+ segmentGenerationProgressCounter.incrementRowProcessedCount();
appenderator.add(segmentIdWithShardSpec, inputRow, null);
+ if (rowsWritten - lastCounterUpdatedRows > 1000) {
Review Comment:
This would be really weird behavior for the end user.
Should we create a class that extends FireDepartMetric and then update the
taskReport as and when relevant calls are made ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
