georgew5656 opened a new pull request, #14010: URL: https://github.com/apache/druid/pull/14010
### Description I was doing some additional testing on my change in https://github.com/apache/druid/pull/14001, and realized that I missed some logic to handle the null job in getJobDuration. This causes a null pointer exception to be thrown when a job is manually shut down. #### Release note - FIx bug with manual task shutdown in the KubernetesTaskRunner - ##### Key changed/added classes in this PR - Explicitly pass null as the job parameter to the JobResponse constructor - Add a log for when the job has been manually cleaned up - Check job null status when grabbing name for logs - [X] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [X] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
