abhishekagarwal87 commented on code in PR #14010:
URL: https://github.com/apache/druid/pull/14010#discussion_r1156708286
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidKubernetesPeonClient.java:
##########
@@ -111,7 +111,8 @@ public JobResponse waitForJobCompletion(K8sTaskId taskId,
long howLong, TimeUnit
unit
);
if (job == null) {
- return new JobResponse(job, PeonPhase.FAILED);
+ log.info("K8s job for task was not found %s", taskId);
Review Comment:
This is better. Though "task was deleted" is more of an implementation
detail. "Task was canceled or pod got terminated" seems better. So if pods were
reaped then users will know immediately. Or if they canceled the job, they will
be able to put two and two together themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
