georgew5656 commented on code in PR #14010:
URL: https://github.com/apache/druid/pull/14010#discussion_r1156527106
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidKubernetesPeonClient.java:
##########
@@ -111,7 +111,8 @@ public JobResponse waitForJobCompletion(K8sTaskId taskId,
long howLong, TimeUnit
unit
);
if (job == null) {
- return new JobResponse(job, PeonPhase.FAILED);
+ log.info("K8s job for task was not found %s", taskId);
Review Comment:
@abhishekagarwal87 I wrongly took this to mean you wanted the reason to
actually be surfaced in the error message so I added it there in addition to
updating this log line.
the error looks like this now
<img width="1209" alt="Screenshot 2023-04-03 at 6 58 23 PM"
src="https://user-images.githubusercontent.com/17736581/229644725-cf663bb3-3f67-412d-a62c-e068d9a004df.png";>
lmk if you think thats too much info to surface in the console and I can
remove that commit, otherwise I addressed the rest of the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/17736581/229644725-cf663bb3-3f67-412d-a62c-e068d9a004df.png"](https://user-images.githubusercontent.com/17736581/229644725-cf663bb3-3f67-412d-a62c-e068d9a004df.png"){kind=link}