clintropolis commented on code in PR #14014:
URL: https://github.com/apache/druid/pull/14014#discussion_r1155480136
##########
processing/src/main/java/org/apache/druid/segment/IndexMergerV9.java:
##########
@@ -335,7 +263,7 @@ private File makeIndexFiles(
// shouldStore AND hasOnlyNulls
ColumnDescriptor columnDesc = ColumnDescriptor
.builder()
- .setValueType(dimCapabilities.get(i).getType())
+ .setValueType(dimFormats.get(i).getLogicalType().getType())
.addSerde(new NullColumnPartSerde(indexMergeResult.rowCount,
indexSpec.getBitmapSerdeFactory()))
.build();
Review Comment:
this is from that explicit null value columns change we did a while back
that saves any dimension schema in the segment that didn't have any values
I agree this can probably be better/smarter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
