imply-cheddar commented on code in PR #14014:
URL: https://github.com/apache/druid/pull/14014#discussion_r1155543219
##########
processing/src/main/java/org/apache/druid/segment/IndexMergerV9.java:
##########
@@ -263,19 +191,19 @@ private File makeIndexFiles(
log.debug("Completed factory.json in %,d millis",
System.currentTimeMillis() - startTime);
progress.progress();
- final Map<String, TypeSignature<ValueType>> metricTypes = new
TreeMap<>(Comparators.naturalNullsFirst());
- final List<ColumnCapabilities> dimCapabilities =
Lists.newArrayListWithCapacity(mergedDimensions.size());
- mergeCapabilities(adapters, mergedDimensions, metricTypes,
dimCapabilities);
+ final Map<String, ColumnFormat> metricTypes = new
TreeMap<>(Comparators.naturalNullsFirst());
+ final List<ColumnFormat> dimFormats =
Lists.newArrayListWithCapacity(mergedDimensions.size());
+ mergeFormat(adapters, mergedDimensions, metricTypes, dimFormats);
- final Map<String, DimensionHandler> handlers =
makeDimensionHandlers(mergedDimensions, dimCapabilities);
+ final Map<String, DimensionHandler> handlers =
makeDimensionHandlers(mergedDimensions, dimFormats);
final List<DimensionMergerV9> mergers = new ArrayList<>();
for (int i = 0; i < mergedDimensions.size(); i++) {
DimensionHandler handler = handlers.get(mergedDimensions.get(i));
mergers.add(
handler.makeMerger(
indexSpec,
segmentWriteOutMedium,
- dimCapabilities.get(i),
+ dimFormats.get(i).toColumnCapabilities(),
progress,
closer
)
Review Comment:
I was thinking that because we are using `CapabilitiesBasedFormat` for all
of the old ones that it would provide a nice clean plain to just start ignoring
this parameter. Though, punting on it for later is probably also fine as even
if we started ignoring it, making the actual interface change is less easy...
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
