clintropolis commented on code in PR #14014:
URL: https://github.com/apache/druid/pull/14014#discussion_r1156566909
##########
processing/src/main/java/org/apache/druid/segment/serde/ComplexMetricSerde.java:
##########
@@ -51,6 +51,21 @@
* @param builder ColumnBuilder to add the column to
* @param columnConfig ColumnConfiguration used during deserialization
*/
+ public void deserializeColumn(
+ @SuppressWarnings("unused") String columnName,
+ ByteBuffer buffer,
+ ColumnBuilder builder,
+ ColumnConfig columnConfig
+ )
+ {
+ deserializeColumn(buffer, builder, columnConfig);
+ }
Review Comment:
removed from this interface since this wasn't needed for the v4 complex
column and has been reverted since it can get the filename from its embedded
metadata.
I have left the parameter on the `ColumnPartSerde.Deserializer` interface
for now because the new nested column part serde does need it since it doesn't
store a separate metadata file embedded in it and
`IndexIO.V9IndexLoader.deserializeColumn` already has the interned
column/filename passed in so i took advantage of this and pushed it down
(instead of writing the column name again inside of the nested part serde or
its data file). This feels like an internal interface so it doesn't seem that
disruptive to change, but can do this other ways if really against it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
