LakshSingla commented on code in PR #13952: URL: https://github.com/apache/druid/pull/13952#discussion_r1159337173
########## processing/src/main/java/org/apache/druid/query/FramesBackedInlineDataSource.java: ########## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query; + +import org.apache.druid.frame.Frame; +import org.apache.druid.frame.read.FrameReader; +import org.apache.druid.frame.segment.FrameStorageAdapter; +import org.apache.druid.java.util.common.IAE; +import org.apache.druid.java.util.common.Intervals; +import org.apache.druid.java.util.common.granularity.Granularities; +import org.apache.druid.java.util.common.guava.Sequence; +import org.apache.druid.java.util.common.guava.Sequences; +import org.apache.druid.query.planning.DataSourceAnalysis; +import org.apache.druid.segment.BaseObjectColumnValueSelector; +import org.apache.druid.segment.ColumnSelectorFactory; +import org.apache.druid.segment.Cursor; +import org.apache.druid.segment.SegmentReference; +import org.apache.druid.segment.VirtualColumns; +import org.apache.druid.segment.column.RowSignature; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; +import java.util.Set; +import java.util.concurrent.atomic.AtomicLong; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** + * Represents an inline datasource where the rows are embedded within the DataSource object itself. + * + * The rows are backed by a sequence of {@link FrameSignaturePair}, which contain the Frame representation of the rows + * represented by the datasource. {@link #getRowsAsList()} and {@link #getRowsAsSequence()} return the iterables which + * read the rows that are encapsulated in the frames. + * + * Note that the signature of the datasource can be different from the signatures of the constituent frames that it + * consists of. While fetching the iterables, it is the job of this class to make sure that the rows correspond to the + * {@link #rowSignature}. For frames that donot contain the columns present in the {@link #rowSignature}, they are + * populated with {@code null}. + */ +public class FramesBackedInlineDataSource implements DataSource +{ + + final Sequence<FrameSignaturePair> frames; + final RowSignature rowSignature; + + public FramesBackedInlineDataSource( + Sequence<FrameSignaturePair> frames, + RowSignature rowSignature + ) + { + this.frames = frames; + this.rowSignature = rowSignature; + } + + public Sequence<FrameSignaturePair> getFrames() + { + return frames; + } + + public RowSignature getRowSignature() + { + return rowSignature; + } + + public List<Object[]> getRowsAsList() Review Comment: Updated and refactored it further to reuse the `rowsAsSequence()`, so that it doesn't do any duplicate computation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
