LakshSingla commented on code in PR #13952:
URL: https://github.com/apache/druid/pull/13952#discussion_r1159338874
##########
processing/src/main/java/org/apache/druid/frame/write/FrameWriters.java:
##########
@@ -58,19 +58,30 @@ public static FrameWriterFactory makeFrameWriterFactory(
final FrameType frameType,
final MemoryAllocatorFactory allocatorFactory,
final RowSignature signature,
- final List<KeyColumn> sortColumns
+ final List<KeyColumn> sortColumns,
+ final boolean allowNullColumnTypes
)
{
switch (Preconditions.checkNotNull(frameType, "frameType")) {
case COLUMNAR:
- return new ColumnarFrameWriterFactory(allocatorFactory, signature,
sortColumns);
+ return new ColumnarFrameWriterFactory(allocatorFactory, signature,
sortColumns, allowNullColumnTypes);
case ROW_BASED:
- return new RowBasedFrameWriterFactory(allocatorFactory, signature,
sortColumns);
+ return new RowBasedFrameWriterFactory(allocatorFactory, signature,
sortColumns, allowNullColumnTypes);
default:
throw new ISE("Unrecognized frame type [%s]", frameType);
}
}
+ public static FrameWriterFactory makeFrameWriterFactory(
Review Comment:
Added this as a separate method originally because we don't require the
boolean in the rest of the cases (i.e. the original ones in MSQ). Therefore it
made sense to me to hide this complexity from the callers of this method that
arent residing in the broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
