abhishekrb19 commented on code in PR #14056:
URL: https://github.com/apache/druid/pull/14056#discussion_r1162316735
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -109,6 +114,15 @@ public String getType()
return TYPE;
}
+ @Nonnull
+ @JsonIgnore
+ @Override
+ public Set<ResourceAction> getInputSourceResources()
+ {
+ // the input sources are properly computed in the SQL / calcite layer, but
not in the native MSQ task here.
Review Comment:
Actually, thinking about it, should we remove the [default
implementation](https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java#L157)
that throws an exception in the `Task` interface? Making the method abstract
would force developers to think about the input security model for our
different task types from the ground up instead of fixing things because of an
unsupported exception at runtime when the feature is enabled. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
