abhishekrb19 commented on code in PR #14056:
URL: https://github.com/apache/druid/pull/14056#discussion_r1162999599
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -109,6 +114,15 @@ public String getType()
return TYPE;
}
+ @Nonnull
+ @JsonIgnore
+ @Override
+ public Set<ResourceAction> getInputSourceResources()
+ {
+ // the input sources are properly computed in the SQL / calcite layer, but
not in the native MSQ task here.
Review Comment:
Thanks for clarifying! One more reason why we cannot remove the default
implementation is it's a method on a common interface and can break compilation
because things can be loaded from custom extensions. So I think having the
default behavior is good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
