zachjsh commented on code in PR #14056:
URL: https://github.com/apache/druid/pull/14056#discussion_r1162333031
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -109,6 +114,15 @@ public String getType()
return TYPE;
}
+ @Nonnull
+ @JsonIgnore
+ @Override
+ public Set<ResourceAction> getInputSourceResources()
+ {
+ // the input sources are properly computed in the SQL / calcite layer, but
not in the native MSQ task here.
Review Comment:
This only throws an exception by default if a the task is used with the
inputSourceType security feature enabled. I think better to default fail than
to allow the the usage of the input source unsecured by default. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
