cryptoe commented on code in PR #14061:
URL: https://github.com/apache/druid/pull/14061#discussion_r1168443597
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerStorageParameters.java:
##########
@@ -58,11 +58,13 @@
*/
private static final long MINIMUM_SUPER_SORTER_TMP_STORAGE_BYTES =
1_000_000_000L;
+ private final boolean isIntermediateStorageLimitConfigured;
private final long intermediateSuperSorterStorageMaxLocalBytes;
- private WorkerStorageParameters(final long
intermediateSuperSorterStorageMaxLocalBytes)
+ private WorkerStorageParameters(final long
intermediateSuperSorterStorageMaxLocalBytes, final boolean
isIntermediateStorageLimitConfigured)
Review Comment:
Can we do this without the new class parameter
`isIntermediateStorageLimitConfigured`.
if someone sets `intermediateSuperSorterStorageMaxLocalBytes` = -1 we treat
the value as not set.
Meaning instead of the class parameter you would have a method which says
```
public boolean isIntermediateStorageLimitConfigured()
{
return !intermediateSuperSorterStorageMaxLocalBytes==-1;
}
```
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/NotEnoughTemporaryStorageFault.java:
##########
@@ -41,7 +41,8 @@ public NotEnoughTemporaryStorageFault(
{
super(
CODE,
- "Not enough temporary storage space. Requires at least %,d bytes.
(configured = %,d bytes)",
+ "Not enough temporary storage space for intermediate files. Requires
at least %,d bytes. (configured = %,d bytes). Increase the limit by increasing
tmpStorageBytesPerTask or "
+ + "disable durable storage to not use disk for temporary intermediate
files.",
Review Comment:
```suggestion
+ "disable durable storage by setting the context parameter blah
blah blah.",
```
Something like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
