cryptoe commented on code in PR #14061:
URL: https://github.com/apache/druid/pull/14061#discussion_r1169481531
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java:
##########
@@ -137,7 +141,8 @@ public TaskConfig(
// deprecated, only set to true to fall back to older behavior
@JsonProperty("batchProcessingMode") String batchProcessingMode,
@JsonProperty("storeEmptyColumns") @Nullable Boolean storeEmptyColumns,
- @JsonProperty("encapsulatedTask") boolean enableTaskLevelLogPush
+ @JsonProperty("encapsulatedTask") boolean enableTaskLevelLogPush,
+ @JsonProperty("tmpStorageBytesPerTask") Long tmpStorageBytesPerTask
Review Comment:
nit: should this be marked nullable ?
##########
docs/configuration/index.md:
##########
@@ -1521,6 +1521,7 @@ Additional peon configs include:
|`druid.indexer.task.restoreTasksOnRestart`|If true, MiddleManagers will
attempt to stop tasks gracefully on shutdown and restore them on restart.|false|
|`druid.indexer.task.ignoreTimestampSpecForDruidInputSource`|If true, tasks
using the [Druid input source](../ingestion/native-batch-input-source.md) will
ignore the provided timestampSpec, and will use the `__time` column of the
input datasource. This option is provided for compatibility with ingestion
specs written before Druid 0.22.0.|false|
|`druid.indexer.task.storeEmptyColumns`|Boolean value for whether or not to
store empty columns during ingestion. When set to true, Druid stores every
column specified in the
[`dimensionsSpec`](../ingestion/ingestion-spec.md#dimensionsspec). If you use
schemaless ingestion and don't specify any dimensions to ingest, you must also
set [`includeAllDimensions`](../ingestion/ingestion-spec.md#dimensionsspec) for
Druid to store empty columns.<br/><br/>If you set `storeEmptyColumns` to false,
Druid SQL queries referencing empty columns will fail. If you intend to leave
`storeEmptyColumns` disabled, you should either ingest dummy data for empty
columns or else not query on empty columns.<br/><br/>This configuration can be
overwritten by setting `storeEmptyColumns` in the [task
context](../ingestion/tasks.md#context-parameters).|true|
+|`druid.indexer.task.tmpStorageBytesPerTask`|Maximum number of bytes per task
to be used to store temporary files on disk. This usage is split among all
temporary storage usages for the task. An exception might be thrown if this
limit is too low for the task or if this limit would be exceeded. This limit is
currently respected only by MSQ tasks. Other types of tasks might exceed this
limit. Must be greater than 0.|9223372036854775807|
Review Comment:
default limit is -1 rite ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
