adarshsanjeev commented on code in PR #14061:
URL: https://github.com/apache/druid/pull/14061#discussion_r1169010742
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerStorageParameters.java:
##########
@@ -58,11 +58,13 @@
*/
private static final long MINIMUM_SUPER_SORTER_TMP_STORAGE_BYTES =
1_000_000_000L;
+ private final boolean isIntermediateStorageLimitConfigured;
private final long intermediateSuperSorterStorageMaxLocalBytes;
- private WorkerStorageParameters(final long
intermediateSuperSorterStorageMaxLocalBytes)
+ private WorkerStorageParameters(final long
intermediateSuperSorterStorageMaxLocalBytes, final boolean
isIntermediateStorageLimitConfigured)
Review Comment:
I initially did it this way since the ByteTracker still needs a default
value(Long.MAX) if it is disabled. However, now I think it would be neater to
move that check there instead to avoid the parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
