abhishekrb19 commented on code in PR #14106:
URL: https://github.com/apache/druid/pull/14106#discussion_r1169493253
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java:
##########
@@ -254,8 +254,8 @@ public void testCorrectInputSourceTypes() throws IOException
Assert.assertEquals(
Collections.singleton(
new ResourceAction(new Resource(
- ResourceType.EXTERNAL,
- LocalInputSource.TYPE_KEY
+ LocalInputSource.TYPE_KEY,
Review Comment:
To avoid any confusion, I think it'd be better to rename all references of
the tests that now invoke `getInputSourceResources` (previously
`getInputSourceTypes`):
- `testCorrectInputSourceTypes` -> `testCorrectInputSourceResources`?
- `hasCorrectInputSourceTypes ` -> `hasCorrectInputSourceResources`
...and so on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
