abhishekrb19 commented on code in PR #14106:
URL: https://github.com/apache/druid/pull/14106#discussion_r1169508247


##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/HadoopIndexTaskTest.java:
##########
@@ -72,8 +72,8 @@ public void testCorrectInputSourceTypes()
     Assert.assertEquals(
         Collections.singleton(
             new ResourceAction(new Resource(
-                ResourceType.EXTERNAL,
-                "hadoop"
+                "hadoop",

Review Comment:
   Perhaps this could be a static variable in `HadoopIndexTask` that can be 
reused here? It'd also clarify the difference between task type and input 
source type:
   ```
     public static final String INPUT_SOURCE_TYPE = "hadoop";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to