LakshSingla commented on code in PR #14270:
URL: https://github.com/apache/druid/pull/14270#discussion_r1193300832
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java:
##########
@@ -762,9 +762,11 @@ public boolean didFail()
*/
Review Comment:
Can you please update the Javadoc for this method? Also please mention both
the conditions separately and what they guardrail, i.e. `currentTimeMillis -
recentFullyStartedWorkerTimeInMs.get() > maxTaskStartDelayMillis` ensures that
no new worker has been launched in the last maxTaskStartDelayMillis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
