kfaraz commented on code in PR #14453:
URL: https://github.com/apache/druid/pull/14453#discussion_r1235011419
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataCache.java:
##########
@@ -403,6 +403,13 @@ public void start() throws InterruptedException
@VisibleForTesting
void refresh(final Set<SegmentId> segmentsToRefresh, final Set<String>
dataSourcesToRebuild) throws IOException
{
+ long startMillis = System.currentTimeMillis();
Review Comment:
Ah, interesting. It does seem that `currentTimeMillis` can sometimes run
backwards!
I still feel `currentTimeMillis` would be a better fit here as it is a
cheaper call and should be (guaranteed to be?) monotonic at least when called
successively from the same thread in the absence of clock adjustments.
But either of the two approaches works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
